Repository navigation
Conversation
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
|
Adding @c3024 / @shubham1206agra here since they did the original review for live markdown mobile |
|
@Skalakid The Cursor after using mention is wrong (it doesn't update to the correct position). |
|
@shubham1206agra I just fixed the bug with cursor positioning, it should have the correct position now |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
|
There is a styling warning thrown if the composer is resized with text in it.
liveMarkDownWarningWeb.mp4 |
@Skalakid This is still not fixed for me :(. |
|
@shubham1206agra are you testing on adhoc build? If no, try removing Screen.Recording.2024-02-07.at.09.14.11.mov |
|
@Skalakid This was on ad-hoc build only. Try using keys for selection. |
|
@shubham1206agra can you record a video with bug reproduction, please? It will be easier to fix it |
This is fixed now. An old ad-hoc build was used to test it again at that time accidentally. |
|
Looks like we're really close - I'm going to generate one last ad hoc to ensure there's no breaking items but looks like we may even be able to merge today? |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
|
@Skalakid @robertKozik One more thing I noticed. Copy-pasting anything multiline is inserting extra lines in between text. |
I noticed this as well but this issue was on |
|
Interesting. It was not on staging. |
|
Extra text breaks are added on staging as well. 🤔 Screen.Recording.2024-02-08.at.5.40.19.PM.mov |
@shubham1206agra Follow up on this one - Expensify/expensify-common#644 |
|
@thienlnam One enhancement is the support of the tooltip for mention in the preview. |
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.39-0 🚀
|
|
BUG (Critical): Macbook keyboard glitch on each key input in composer bug.mp4 |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.39-8 🚀
|
|
@situchan Could you give us more details about the mac that you're experiencing this bug on? #35837 (comment) Model / OSX version / Browser |
Macbook Pro 2019 / Sonoma 14.0 / Chrome |


This PR adds Live Markdown Preview feature for web using @expensify/react-native-live-markdown library. Previously Markdown Input was added only for native devices in #34292.
Details
Fixed Issues
$ #27977
PROPOSAL:
Tests
Testing Replacement Rules
Code Fence:
Type:
your textExpected: Text appears in a separate block formatted as code.
Inline Code Block:
Type:
your textExpected: Text appears inline, formatted as code.
Email Link:
Type: test@email.com
Expected: Email address turns into a clickable mailto link.
URL Link:
Type:
https://github.com/Expensify/App/pull/34292Expected: Displays
https://github.com/Expensify/App/pull/34292styled as web link (it shouldn't be clickable).Italics
Type: your text
Expected: Text appears in italics.
Bold Text:
Type: your text
Expected: Text appears in bold.
Strikethrough Text:
Type:
your textExpected: Text appears with a strikethrough.
Block Quote:
Type: > your text
Expected: Text appears as a block quote.
Heading:
Type: # Your Heading
Expected: Text appears as a large, bold heading.
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop